Add Google Cloud Build build config file#154
Open
mans0954 wants to merge 5 commits intoStackdriver:masterfrom
Open
Add Google Cloud Build build config file#154mans0954 wants to merge 5 commits intoStackdriver:masterfrom
mans0954 wants to merge 5 commits intoStackdriver:masterfrom
Conversation
Contributor
|
Hi Christopher. Can you explain the motivation behind this PR? Our team doesn't use Cloud Build for this particular project. Thanks. |
Contributor
Author
|
Dear David, Unfortunately we're finding it necessary to build our own fork of stackdriver-prometheus-sidecar, as the official builds have a couple of issues which are show-stoppers for us. Having composed a cloudbuild.yaml file for my employer's use, we thought we'd offer it upstream in case it was of use to anyone else in the same predicament. Christopher |
davidbtucker
approved these changes
Sep 9, 2019
Contributor
davidbtucker
left a comment
davidbtucker
left a comment
There was a problem hiding this comment.
LGTM with two minor changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
cloudbuild.yamlfile for building the stackdriver-prometheus-sidecar binary and docker image with Google's Cloud Build service.